BufmgrCommit no-op since 2008, remaining uses?

From: Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Subject: BufmgrCommit no-op since 2008, remaining uses?
Date: 2023-03-29 11:51:36
Message-ID: CAEze2Wi1=tLKbxZnXzcD+8fYKyKqBtivVakLQC_mYBsP4Y8qVA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

Whilst reading up on the transaction commit code, I noticed the following lines:

/* Tell bufmgr and smgr to prepare for commit */
BufmgrCommit();

BufmgrCommit does exactly nothing; it is an empty function and has
been since commit 33960006 in late 2008 when it stopped calling
smgrcommit().

All two usages of the function (in our code base) seem to be in
xact.c. Are we maintaining it for potential future use, or can the
function be removed?

Kind regards,

Matthias van de Meent

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2023-03-29 11:55:43 Re: [PATCH] Allow Postgres to pick an unused port to listen
Previous Message Amit Kapila 2023-03-29 11:07:43 Re: Initial Schema Sync for Logical Replication