Re: Why doesn't GiST VACUUM require a super-exclusive lock, like nbtree VACUUM?

From: Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>
To: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Peter Geoghegan <pg(at)bowt(dot)ie>
Cc: vignesh C <vignesh21(at)gmail(dot)com>, Michail Nikolaev <michail(dot)nikolaev(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de>, Tomas Vondra <tomas(at)vondra(dot)me>
Subject: Re: Why doesn't GiST VACUUM require a super-exclusive lock, like nbtree VACUUM?
Date: 2025-12-24 11:54:48
Message-ID: CAEze2Whi+CiZpMQ=Y2dQ8U=r-jAY5z-HAs1Zq9nJTMPv4rGRqA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, 22 Dec 2025 at 23:23, Matthias van de Meent
<boekewurm+postgres(at)gmail(dot)com> wrote:
>
> On Thu, 24 Apr 2025 at 22:46, Matthias van de Meent
> <boekewurm+postgres(at)gmail(dot)com> wrote:
> >
> > On Fri, 21 Mar 2025 at 17:14, Matthias van de Meent
> > <boekewurm+postgres(at)gmail(dot)com> wrote:
> > > Attached is v10, which polishes the previous patches, and adds a patch
> > > for nbtree to use the new visibility checking strategy so that it too
> > > can release its index pages much earlier, and adds a similar
> > > visibility check test to nbtree.
> >
> > And here's v12. v11 (skipped) would've been a rebase, but after
> > finishing the rebase I noticed a severe regression in btree's IOS with
> > the new code, so v12 here applies some optimizations which reduce the
> > overhead of the new code.
>
> Here's v13, which moves the changes around a bit:

CFBot reported failures, which appeared to be due to an oversight in
patch 0001, where visibilitymap_get_status was missing a static
modifier to accompany its inline nature.

Apart from that fix v14 is identical to v13.

Kind regards,

Matthias van de Meent

Attachment Content-Type Size
v14-0007-nbtree-Reduce-Index-Only-Scan-pin-duration.patch application/octet-stream 10.7 KB
v14-0008-Test-for-IOS-Vacuum-race-conditions-in-index-AMs.patch application/octet-stream 16.3 KB
v14-0004-IOS-Support-tableAM-powered-prechecked-visibilit.patch application/octet-stream 9.3 KB
v14-0005-GIST-Fix-visibility-issues-in-IOS.patch application/octet-stream 9.4 KB
v14-0006-SP-GIST-Fix-visibility-issues-in-IOS.patch application/octet-stream 12.5 KB
v14-0002-pg_visibility-vectorize-collect_visibility_data.patch application/octet-stream 2.9 KB
v14-0001-Add-vectorized-API-for-visibility-map-lookup.patch application/octet-stream 8.6 KB
v14-0003-TableAM-Support-AM-specific-fast-visibility-test.patch application/octet-stream 12.1 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message vignesh C 2025-12-24 11:59:15 Re: Proposal: Conflict log history table for Logical Replication
Previous Message Jeevan Chalke 2025-12-24 11:44:18 Add --extra-dependencies and immediate data dumping for pg_dump/pg_upgrade