| From: | Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com> |
|---|---|
| To: | |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Michel Pelletier <pelletier(dot)michel(at)gmail(dot)com> |
| Subject: | Re: Reducing output size of nodeToString |
| Date: | 2024-02-12 23:10:56 |
| Message-ID: | CAEze2WhR_99QHboeXU73u8tc_N4zSnkoyhpm8ZuRS6gh49ZGjw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 12 Feb 2024 at 20:32, Matthias van de Meent
<boekewurm+postgres(at)gmail(dot)com> wrote:
>
> On Mon, 12 Feb 2024 at 19:03, Matthias van de Meent
> <boekewurm+postgres(at)gmail(dot)com> wrote:
> > Attached is patchset v2, which contains the improvements from these patches:
>
> Attached v3, which fixes an out-of-bounds read in pg_strtoken_next,
> detected by asan, that was a likely cause of the problems in CFBot's
> FreeBSD regression tests.
Apparently that was caused by issues in my updated bitmapset
serializer; where I used bms_next_member(..., x=0) as first iteration
thus skipping the first bit. This didn't show up earlier because that
bit is not exercised in PG's builtin views, but is exercised when
WRITE_READ_PARSE_PLAN_TREES is defined (as on the FreeBSD CI job).
Trivial fix in the attached v4 of the patchset, with some fixes for
other assertions that'd get some exercise in non-pg_node_tree paths in
the WRITE_READ configuration.
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-pg_node_tree-Omit-serialization-of-fields-with-de.patch | application/octet-stream | 23.0 KB |
| v4-0002-pg_node_tree-Don-t-store-query-text-locations-in-.patch | application/octet-stream | 19.2 KB |
| v4-0005-nodeToString-omit-serializing-NULL-datums-in-Cons.patch | application/octet-stream | 1.9 KB |
| v4-0004-gen_node_support.pl-Add-a-TypMod-type-for-signall.patch | application/octet-stream | 10.4 KB |
| v4-0003-gen_node_support.pl-Mark-location-fields-as-type-.patch | application/octet-stream | 26.4 KB |
| v4-0007-gen_node_support.pl-Optimize-serialization-of-fie.patch | application/octet-stream | 9.2 KB |
| v4-0006-nodeToString-Apply-RLE-on-Bitmapset-and-numeric-L.patch | application/octet-stream | 7.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2024-02-12 23:36:48 | Re: Improve WALRead() to suck data directly from WAL buffers when possible |
| Previous Message | Nathan Bossart | 2024-02-12 23:04:23 | Re: glibc qsort() vulnerability |