Re: Init connection time grows quadratically

On Fri, 7 Aug 2026 at 16:05, Maksim.Melnikov <m(dot)melnikov(at)postgrespro(dot)ru> wrote:
>
>
> On 7/17/26 11:54, Matthias van de Meent wrote:
> > On Thu, 11 Jun 2026 at 16:31, Maksim.Melnikov <m(dot)melnikov(at)postgrespro(dot)ru> wrote:
> >> Patch with fixes was attached. Thanks for review.
> > You removed the pgxactoff field with its comment from PGPROC, but
> > haven't yet added a comment on PROC_HDR's pgxactoffs. Please add a
> > comment to the pgxactoffs array that describes its contents. A simple
> > adaptation of the comment removed with PGPROC's pgxactoff field should
> > be sufficient.
> >
> > The comments on PROC_HDR and PGPROC also reference the deleted
> > PGPROC->pgxactoff field, so that also must be adjusted; there may be
> > several other places, as I didn't do a full check on the codebase.
> >
> > Once the relevant comments are added and adjusted I think this is
> > ready for a committer.
> >
> >
> > Kind regards,
> >
> > Matthias van de Meent
> > Databricks (https://www.databricks.com)
> >
> >
> Sorry for the delay, was unavailable for several weeks.
>
> Thanks for review, patch was updated.

I noticed this patch wasn't registered at the commitfest yet, so I
took the liberty to do that for you. It's registered at [0].

The CFBot then noticed crashes caused by the patch in various tests,
which I think can be caused by a lack of initialization of pgxactoffs
in ProcArrayShmemAttach, but I haven't worked on a fix.

Attached are some copy-edits of comments on top of your v3, and a
missed replacement of "GetNumberFromPGProc(MyProc)" with
"MyProcNumber".

This is an incremental patch on your v3, and doesn't fix the CFBot failures.

Kind regards,

Matthias van de Meent
Databricks (https://www.databricks.com)

[0]: https://commitfest.postgresql.org/patch/7139/