Re: BufmgrCommit no-op since 2008, remaining uses?

On Wed, 29 Mar 2023 at 14:12, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com> writes:
> > BufmgrCommit does exactly nothing; it is an empty function and has
> > been since commit 33960006 in late 2008 when it stopped calling
> > smgrcommit().
> > All two usages of the function (in our code base) seem to be in
> > xact.c. Are we maintaining it for potential future use, or can the
> > function be removed?
>
> Seems reasonable. Even if bufmgr grew a new need to be called
> during commit, it would quite possibly need to be called from
> a different spot; so I doubt that the function is useful even
> as a placeholder.

Then, the attached trivial patch removes the function and all
references I could find.

Kind regards,

Matthias van de Meent