Re: [HACKERS] Bug in Physical Replication Slots (at least 9.5)?

From: Venkata B Nagothi <nag1010(at)gmail(dot)com>
To: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
Cc: Jonathon Nelson <jdnelson(at)dyn(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, PostgreSQL Bugs <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: [HACKERS] Bug in Physical Replication Slots (at least 9.5)?
Date: 2017-03-29 23:49:21
Message-ID: CAEyp7J_k-_qEE74B039XCK5UXVK_vqFZqdzx4GNpXLrdhAjzXw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

Regards,

Venkata B N
Database Consultant

On Tue, Mar 28, 2017 at 5:51 PM, Kyotaro HORIGUCHI <
horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> wrote:

> This conflicts with 6912acc (replication lag tracker) so just
> rebased on a6f22e8.
>

I tried applying this patch to latest master, it is not getting applied

[dba(at)buildhost postgresql]$ git apply
/data/postgresql-patches/9.5-ReplicationSlots-Bug-Patch/0001-Fix-a-bug-of-physical-replication-slot_a6f22e8.patch
/data/postgresql-patches/9.5-ReplicationSlots-Bug-Patch/0001-Fix-a-bug-of-physical-replication-slot_a6f22e8.patch:28:
trailing whitespace.
/*
/data/postgresql-patches/9.5-ReplicationSlots-Bug-Patch/0001-Fix-a-bug-of-physical-replication-slot_a6f22e8.patch:29:
trailing whitespace.
* This variable corresponds to restart_lsn in pg_replication_slots for a
/data/postgresql-patches/9.5-ReplicationSlots-Bug-Patch/0001-Fix-a-bug-of-physical-replication-slot_a6f22e8.patch:30:
trailing whitespace.
* physical slot. This has a valid value only when it differs from the
current
/data/postgresql-patches/9.5-ReplicationSlots-Bug-Patch/0001-Fix-a-bug-of-physical-replication-slot_a6f22e8.patch:31:
trailing whitespace.
* flush pointer.
/data/postgresql-patches/9.5-ReplicationSlots-Bug-Patch/0001-Fix-a-bug-of-physical-replication-slot_a6f22e8.patch:32:
trailing whitespace.
*/
error: patch failed: src/backend/replication/walsender.c:210
error: src/backend/replication/walsender.c: patch does not apply

Regards,

Venkata Balaji N
Database Consultant

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Michael Paquier 2017-03-29 23:55:08 Re: [BUGS] Bug in Physical Replication Slots (at least 9.5)?
Previous Message shaunc 2017-03-29 21:36:07 BUG #14605: round trip of day of week doesn't work

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2017-03-29 23:55:08 Re: [BUGS] Bug in Physical Replication Slots (at least 9.5)?
Previous Message Michael Paquier 2017-03-29 23:28:44 Re: [PATCH] Reduce src/test/recovery verbosity