From: | Vinayak Pokale <vinpokale(at)gmail(dot)com> |
---|---|
To: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: [PROPOSAL] VACUUM Progress Checker. |
Date: | 2016-01-26 02:22:44 |
Message-ID: | CAEySZvg=RShEj1=wJnobNO7znebLBw=P2kVtt3Mc03mmhLSBiw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi Amit,
Thank you for reviewing the patch.
On Jan 26, 2016 9:51 AM, "Amit Langote" <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
wrote:
>
>
> Hi Vinayak,
>
> On 2016/01/25 20:58, Vinayak Pokale wrote:
> > Hi,
> >
> > Please find attached updated patch with an updated interface.
> >
>
> Thanks for updating the patch.
>
> > I added the below interface to update the
> > scanned_heap_pages,scanned_index_pages and index_scan_count only.
> > void pgstat_report_progress_scanned_pages(int num_of_int, uint32
> > *progress_scanned_pages_param)
>
> I think it's still the same interface with the names changed. IIRC, what
> was suggested was to provide a way to not have to pass the entire array
> for the update of a single member of it. Just pass the index of the
> updated member and its new value. Maybe, something like:
>
> void pgstat_progress_update_counter(int index, uint32 newval);
>
> The above function would presumably update the value of
> beentry.st_progress_counter[index] or something like that.
Understood. I will update the patch.
Regards,
Vinayak
From | Date | Subject | |
---|---|---|---|
Next Message | Vitaly Burovoy | 2016-01-26 05:25:34 | Re: custom function for converting human readable sizes to bytes |
Previous Message | Kouhei Kaigai | 2016-01-26 02:09:58 | Re: [Proposal] Table partition + join pushdown |