Re: Fix DROP PROPERTY GRAPH "unsupported object class" error

From: Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Alex Guo <guo(dot)alex(dot)hengchen(at)gmail(dot)com>, Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Fix DROP PROPERTY GRAPH "unsupported object class" error
Date: 2026-06-10 11:00:24
Message-ID: CAExHW5vZN5ADVaXj0X9Xq1gnShUr4SxjXTL5F4MwjzcD65sJzA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jun 10, 2026 at 10:49 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Wed, Jun 10, 2026 at 09:28:56AM +0530, Ashutosh Bapat wrote:
> > Here's a patch fixing it.
>
> Based on the definitions of pglpgid/pgepgid/pgppgid (property graph
> relations), pgelelid (property graph element) and plpellabelid
> (property graph element label), that looks better. I am still puzzled
> regarding the choice of "label" in the patch for plpellabelid while it
> is an "element label" based on the way it is stored in its catalog,
> with the catalog matching the object being named "property graph
> element label".
>

Which specific string you are referring to?

property graph element label | | | e of element e of
property graph create_property_graph_tests.gt - that doesn't have a
bare label in there

probably the next one
property graph label property | | | a of label v1 of
element v1 of property graph create_property_graph_tests.gt

The term "element" comes later "label v1 of element v1". There's
nothing in the standard called "element label". That term is an
artifact of our implementation. I think "label v1 of element v1" reads
better and follows the standard compared to "element label v1 of
element v1".

There's also a precedent of not using exact catalog names. In case of
user mapping we say " %s of server ...", we don't use "foreign server"
there even though the object is called "foreign server" and the
catalog is pg_foreign_server.

--
Best Wishes,
Ashutosh Bapat

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jakub Wartak 2026-06-10 11:13:49 Re: Heads Up: cirrus-ci is shutting down June 1st
Previous Message Ashutosh Bapat 2026-06-10 10:50:18 Re: GetBufferDescriptor() being called for local buffers from MarkBufferDirtyHint()