Re: [PATCH v1] Fix for bug #19773 : pg_dump differing generation expressions of inherited columns

On Tue, Nov 3, 2026 at 11:28 AM Henson Choi <assam258(at)gmail(dot)com> wrote:
>
> Hi Nitin,
>
> I have looked at v2. Below are my notes on the multi-parent scenario,
> and on how the backend problem where the restored child loses its
> inherited CHECK constraint shows up with v2.

I didn't look at the whole patch and don't intend to review. I noticed
that this patch adds tests to pg_dump TAP test. Instead, we should
check whether we can leverage 002_pg_upgrade for this testing - if
there are test in regression suite that render the objects in the
required state, leave them in regression database at the end. If the
tests do not do that, probably we are missing respective DDL coverage
in regression suite itself.

--
Best Wishes,
Ashutosh Bapat