Re: Allow REPLICA IDENTITY with CREATE TABLE statement

From: Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>
To: Kirill Reshke <reshkekirill(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Allow REPLICA IDENTITY with CREATE TABLE statement
Date: 2025-08-08 11:11:56
Message-ID: CAExHW5v2EHaYtGrk7wbN+79UYU4_u61jjs79wG9pSKunaogrnw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Aug 7, 2025 at 6:31 PM Kirill Reshke <reshkekirill(at)gmail(dot)com> wrote:
>
> Hi hackers!
>
> In the nearby thread[0], enhancements for CREATE TABLE LIKE/REPLICA
> IDENTITY were proposed.
>
> > To me, it makes sense to copy the replica identity definition if
> INCLUDING INDEXES or INCLUDING CONSTRAINTS is given.
>
> I agree that this can be beneficial.
>
> But I decided to start with some simpler task, which is also sane (to
> my belief) and can be used to improve user experience with this
> feature. This is to allow you to specify REPLICA IDENTITY with CREATE
> TABLE statement. Currently, it requires 2 (two) DDL statements to
> define RI for relation (that is CREATE TABLE + ALTER TABLE). My patch
> indent to enhance this.
>
> This was actually proposed 12 years ago in the original thread, see
> [1]. But at that time this was not considered vital for logical
> replication to work, so was abandoned.
>
> My v1 patch misses documentation and tests, yes, but this is just the
> initial version to receive feedback, if this has a chance of being
> committed or not, and general thoughts on the subject.

I bumped into this requirement recently when working for a customer
case. The previous discussion isn't thorough and doesn't show that we
didn't want this feature that time. +1 for the feature.

I haven't reviewed the patches though.

--
Best Wishes,
Ashutosh Bapat

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Ashutosh Bapat 2025-08-08 11:48:55 Re: Dropping publication breaks logical replication
Previous Message Xuneng Zhou 2025-08-08 11:06:12 Re: Add progressive backoff to XactLockTableWait functions