| From: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> |
|---|---|
| To: | Junwang Zhao <zhjwpku(at)gmail(dot)com> |
| Cc: | Nathan Bossart <nathandbossart(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Use RELATION_IS_OTHER_TEMP where possible |
| Date: | 2025-06-11 11:10:49 |
| Message-ID: | CAExHW5v+eWp0dVg4e-_d9-7Z4HSQYKK6iZ5JsFeHyBK-WGHE_w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jun 11, 2025 at 5:12 AM Junwang Zhao <zhjwpku(at)gmail(dot)com> wrote:
> Hi Nathan,
>
> On Wed, Jun 11, 2025 at 12:30 AM Nathan Bossart
> <nathandbossart(at)gmail(dot)com> wrote:
> >
> > On Wed, Jun 11, 2025 at 12:07:35AM +0800, Junwang Zhao wrote:
> > > All other files perform this check using RELATION_IS_OTHER_TEMP.
> > > Should we update tablecmds.c to do the same for consistency?
> >
> > Seems like a good idea.
>
> Thanks for the comment.
>
> I have attached a patch with the proposed changes.
>
LGTM. I looked at other instances of is_localtemp, but none of them
have (relation)->rd_rel->relpersistence == RELPERSISTENCE_TEMP there. Your
patch has covered all the existing ones.
--
Best Wishes,
Ashutosh Bapat
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David G. Johnston | 2025-06-11 11:11:22 | Re: Possibly hard-to-read message |
| Previous Message | Amit Kapila | 2025-06-11 10:53:19 | Re: Replication slot is not able to sync up |