| From: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> |
|---|---|
| To: | Sami Imseih <samimseih(at)gmail(dot)com> |
| Cc: | Nathan Bossart <nathandbossart(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pg_get_multixact_members not documented |
| Date: | 2025-06-12 04:22:55 |
| Message-ID: | CAExHW5ucn=R39HE7JFEFS18s0jZEu9K=kFb2x=waC1oQKva1XA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jun 11, 2025 at 9:44 PM Sami Imseih <samimseih(at)gmail(dot)com> wrote:
> > It's not clear, without some effort, which lock mode go with which row
> lock in that description.
> > For example, "keysh" does not have "for" in it but "fornokeyupd" does.
> How about rephrasing this
> > as "The lock modes "keysh", "sh", fornokeyupd", and "forupd" correspond
> to
> > <literal>FOR KEY SHARE</literal>, <literal>FOR SHARE</literal>,
> <literal>FOR NO KEY UPDATE</literal>,
> > and <literal>FOR UPDATE</literal> row level locks respectively as
> described in <xref linkend="locking-rows"/>."
>
> That works for me.
>
> > Do we want to add the section "Multixact Information Functions" after
> other transaction related
> > sections like "Transaction ID and Snapshot Information Function" and
> > " Committed Transaction Information Functions" instead of adding it at
> the end?
>
> makes sense.
>
>
Attached patch removing extra comma. Otherwise LGTM.
Please add the patch to CF, if not already done and mark it as "ready for
committer".
--
Best Wishes,
Ashutosh Bapat
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Document-pg_get_multixact_members-20250612.patch | text/x-patch | 3.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Shirisha Shirisha | 2025-06-12 04:46:57 | Proposal to allow DELETE/UPDATE on partitioned tables with unsupported foreign partitions |
| Previous Message | Tatsuo Ishii | 2025-06-12 03:52:13 | Re: [PATCH] Proposal: Improvements to PDF stylesheet and table column widths |