| From: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> |
|---|---|
| To: | shveta malik <shveta(dot)malik(at)gmail(dot)com> |
| Cc: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Report bytes and transactions actually sent downtream |
| Date: | 2025-11-03 14:23:30 |
| Message-ID: | CAExHW5u_aG+94p8bTXRZmM0VEaDxYurprTddvNjpVx2gVkujqg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Nov 3, 2025 at 3:25 PM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
>
> > So I propose to just add comment
> >
> > in pgoutput_truncate()
> > /*
> > * Even if we filtered out some relations, we still send a TRUNCATE
> > * message for the remaining relations. Since the change, as a whole, is
> > * not filtered out we don't increment filteredBytes.
> > */
> >
> > and in pgoutput_change
> > /*
> > * Send the data. Even if we end up filtering some columns while sending the
> > * message, we won't consider the change, as a whole, to be filtered out. Hence
> > * won't increment the filteredBytes.
> > */
> >
> > Does that look good?
>
> Yes. Works for me.
Here's a patch with all comments addressed.
--
Best Wishes,
Ashutosh Bapat
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Report-output-plugin-statistics-in-pg_stat_-20251103.patch | text/x-patch | 54.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2025-11-03 14:24:37 | Re: Make PGOAUTHCAFILE in libpq-oauth work out of debug mode |
| Previous Message | cca5507 | 2025-11-03 14:13:05 | Fix outdated comment of CopyStmt in gram.y |