Re: gcov coverage data not full with immediate stop

From: Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>
To: Alexander Lakhin <exclusion(at)gmail(dot)com>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: gcov coverage data not full with immediate stop
Date: 2020-05-11 12:26:33
Message-ID: CAExHW5u_0u=YdnvaRYNrYBFxJowZai7L4u5LiYUJY8=swS1i6w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, May 11, 2020 at 2:30 PM Alexander Lakhin <exclusion(at)gmail(dot)com> wrote:

>
> But I can confirm that calling __gcov_flush() in SignalHandlerForCrashExit() really improves a code coverage report.
>
> Finally I've managed to get an expected coverage when I performed $node_standby->stop() (but __gcov_flush() in SignalHandlerForCrashExit() helps too).

What happens if a coverage tool other than gcov is used? From that
perspective, it's better to perform a clean shutdown in the TAP tests
instead of immediate if that's possible.

--
Best Wishes,
Ashutosh Bapat

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Julien Rouhaud 2020-05-11 12:53:59 Re: Add "-Wimplicit-fallthrough" to default flags (was Re: pgsql: Support FETCH FIRST WITH TIES)
Previous Message Amit Kapila 2020-05-11 12:12:42 Re: Parallel copy