| From: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> |
|---|---|
| To: | Joseph Koshakow <koshy44(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Gregory Stark (as CFM)" <stark(dot)cfm(at)gmail(dot)com>, jian he <jian(dot)universality(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Infinite Interval |
| Date: | 2023-03-24 13:43:39 |
| Message-ID: | CAExHW5tuWBmSdDkv=b+cgWhtrHUEsxJmW+9bn4y=qHFuQmw+Ng@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Mar 19, 2023 at 1:04 AM Joseph Koshakow <koshy44(at)gmail(dot)com> wrote:
>
> The patches in this email should be rebased over master.
>
Reviewed 0001 -
Looks good to me. The new function is properly placed along with other
signed 64 bit functions. All existing calls to int64_multiply_add()
have been replaced with the new function and negated the result.
Reviewed 0002
+ result->day = days;
+ if (pg_mul_add_s32_overflow(weeks, 7, &result->day))
You don't need to do this, but looks like we can add DAYS_PER_WEEK macro and
use it here.
The first two patches look good to me; ready for a committer. Can be
committed independent of the third patch.
Will look at the third patch soon.
--
Best Wishes,
Ashutosh Bapat
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2023-03-24 14:00:36 | Re: running logical replication as the subscription owner |
| Previous Message | Imseih (AWS), Sami | 2023-03-24 13:32:43 | Re: [BUG] pg_stat_statements and extended query protocol |