Re: Allow pg_dump --statistics-only to dump foreign table statistics?

From: Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Allow pg_dump --statistics-only to dump foreign table statistics?
Date: 2025-06-13 12:35:44
Message-ID: CAExHW5trd-DdBWJ1iYd6eiBFJp=x59Bf9Heex8j1Ewo0a6yoqw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jun 13, 2025 at 1:19 PM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
> > On 13 Jun 2025, at 09:19, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote:
>
> > I noticed that pg_restore_relation|attribute_stats() can restore statistics
> > for foreign tables, but pg_dump --statistics-only doesn't include them.
> > Is there a reason why pg_dump skips statistics for foreign tables?
> > Are there any risks or concerns around including them?
>
> That indeed seems like an oversight, and regardless it's unclear to the user
> what actually happens. Question is, since we don't know what's on the other
> end do we need a corresponding option to --include-foreign-data to be able to
> be selective with statistics?

We include only statistics and no data for regular tables. Shouldn't
we do the same to the foreign tables?

--
Best Wishes,
Ashutosh Bapat

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Shubhankar Anand Kulkarni 2025-06-13 13:04:45 Re: Expression push down from Join Node to below node.
Previous Message Amit Kapila 2025-06-13 09:58:42 Re: Question on error code selection in conflict detection