Re: GetBufferDescriptor() being called for local buffers from MarkBufferDirtyHint()

On Thu, Jul 2, 2026 at 10:16 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Wed, Jul 01, 2026 at 08:00:38PM +0530, Ayush Tiwari wrote:
> > v2 attached sets NLocBuffer = nbufs before the initialization loop, so the
> > loop can keep using GetLocalBufferDescriptor(), and drops the now-redundant
> > assignment at the end.
>
> Catching up with the latest activity of this thread now that v20 has
> opened up. That's kind of nice.
>
> I have been also reminded about BufferIsValid(), where we already have
> similar assertions. As a whole, that seems acceptable to me, and
> using unsigned still does not make much sense here.
>
> Any thoughts or objections regarding a HEAD-only change?

We usually do not backport changes to function definitions or new
assertions, unless they are critical to the fix. That is not the case
here. The functions have been in this state for a couple of releases
and we haven't heard any complaints. Overall HEAD-only is fine with
me.

If required we can always backport, the functions are static so they
won't cause an ABI break. The Assertions are applicable in those
branches as well.

--
Best Wishes,
Ashutosh Bapat