| From: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
| Subject: | Re: Use T_IntList for uint32 |
| Date: | 2020-08-31 12:14:03 |
| Message-ID: | CAExHW5tZBAPs8XHtMUF8QVayLGqUBw=hxB5KTEyr0v9_SQvvdQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Aug 31, 2020 at 4:59 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> Now, as far as I can see there is no problem in using T_IntList in
> such usage because we are not going to fetch stored unsigned value as
> a signed value, so the comparison in get_schema_sent_in_streamed_txn
> should work well. However, still, I thought it would be better if
> there is a built-in T_UIntList.
>
> Thoughts?
May be we should have separate list APIs for XID like OID, in case we
change underlying datatype of XID in future (unlikely but we have had
discussion about 64bit XIDs in the past). Apart from that it helps us
track code which deals with XID lists.
--
Best Wishes,
Ashutosh Bapat
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ashutosh Bapat | 2020-08-31 13:19:21 | Re: Ideas about a better API for postgres_fdw remote estimates |
| Previous Message | Pavel Borisov | 2020-08-31 12:02:22 | Re: Yet another fast GiST build (typo) |