Re: SQL Property Graph Queries (SQL/PGQ)

On Tue, Jan 13, 2026 at 3:47 PM Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
>
> On 02.01.26 09:48, Ashutosh Bapat wrote:
> >> #1 [Code] src/backend/commands/propgraphcmds.c:1632
> >> FIXME: Missing index for plppropid column causes sequential scan.
> >> Decision needed: (a) add index, or (c) allow seq scan for rare path.
> >
> > The path is rare enough that I think we can allow the seq scan. Given
> > that Peter has marked it as FIXME, it seems we will keep it as is for
> > now, but will revisit if performance becomes an issue. Peter, please
> > correct me if I'm wrong.
>
> Yeah, doesn't seem critical. Maybe "downgrade" to "XXX".

I see you have done in the patch attached to your next response.

>
> >> #5 [Doc] doc/src/sgml/queries.sgml:2929,2931
> >> TODO comments for unimplemented features without clear limitation notes.
> >
> > Those TODOs are not visible to users. I think they serve as
> > placeholders to add the documentation when the features are
> > implemented. We may want to remove them, but I see no harm in keeping
> > them for now. Peter, what do you think?
>
> We should keep them and fill them in. :)
>

Works for me.

--
Best Wishes,
Ashutosh Bapat