| From: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> |
|---|---|
| To: | Amit Langote <amitlangote09(at)gmail(dot)com> |
| Cc: | Richard Guo <guofenglinux(at)gmail(dot)com>, Andrei Lepikhov <a(dot)lepikhov(at)postgrespro(dot)ru>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, vignesh C <vignesh21(at)gmail(dot)com> |
| Subject: | Re: Memory consumed by child SpecialJoinInfo in partitionwise join planning |
| Date: | 2024-03-25 10:56:34 |
| Message-ID: | CAExHW5tJU=gg6L5t5yqfLBv-+bO3NcNZKziKfciSJPStjOmh7g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Mar 25, 2024 at 4:01 PM Amit Langote <amitlangote09(at)gmail(dot)com>
wrote:
> On Mon, Mar 25, 2024 at 7:25 PM Richard Guo <guofenglinux(at)gmail(dot)com>
> wrote:
> > On Mon, Mar 25, 2024 at 5:17 PM Amit Langote <amitlangote09(at)gmail(dot)com>
> wrote:
> >> I've pushed this now.
> >>
> >> When updating the commit message, I realized that you had made the
> >> right call to divide the the changes around not translating the dummy
> >> SpecialJoinInfos into a separate patch. So, I pushed it like that.
> >
> >
> > Sorry I'm late for the party. I noticed that in commit 6190d828cd the
> > comment of init_dummy_sjinfo() mentions the non-existing 'rel1' and
> > 'rel2', which should be addressed.
>
> Thanks for catching that. Oops.
>
Good catch.
>
> > Also, I think we can make function
> > consider_new_or_clause() call init_dummy_sjinfo() to simplify the code a
> > bit.
>
> Indeed.
>
Thanks for fixing it.
--
Best Wishes,
Ashutosh Bapat
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jelte Fennema-Nio | 2024-03-25 11:03:31 | Re: session username in default psql prompt? |
| Previous Message | Ashutosh Bapat | 2024-03-25 10:43:10 | Re: DOCS: add helpful partitioning links |