Re: Error handling in after-startup shmem requests

From: Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>
To: Ayush Tiwari <ayushtiwari(dot)slg01(at)gmail(dot)com>
Cc: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Error handling in after-startup shmem requests
Date: 2026-08-12 09:41:47
Message-ID: CAExHW5t981HsAQE90FdbmV+zUySFd6kL6owzhT5LkfYK2NUgnw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Aug 12, 2026 at 2:37 PM Ayush Tiwari
<ayushtiwari(dot)slg01(at)gmail(dot)com> wrote:

> Thanks for the latest patch, it looks good to me.
>

Thanks.

> I just have 2 minor editorial nits:
>
> - The commit message mentions CallShmemCallbacksAfterStartupCleanup(), but I
> think that should be CallShmemCallbacksAfterStartup().
>
> - "unitialized" in xfunc.sgml should be "uninitialized".
>
> These can be adjusted while committing so I'm not sending an updated patch.
>

Attached patch fixes those two as well.

>
>
> Here's the CF entry I had created:
> https://commitfest.postgresql.org/patch/7115/

I see Meson MacOS build failing, but the issue seems to be with
downloading dependencies. The CI will be triggered again with a new
patch and hopefully we will see the failure gone.

--
Best Wishes,
Ashutosh Bapat

Attachment Content-Type Size
v20260812_2-0001-Cleanup-after-failed-shared-memory-request.patch text/x-patch 13.8 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2026-08-12 09:51:57 Re: LibreSSL and OpenSSL separation in libpq to support 1.1.1 deprecation
Previous Message Tomas Vondra 2026-08-12 09:34:33 Re: WAL compression setting after PostgreSQL LZ4 default change