| From: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> |
|---|---|
| To: | Naga Appani <nagnrik(at)gmail(dot)com> |
| Cc: | Tomas Vondra <tomas(at)vondra(dot)me>, Xuneng Zhou <xunengzhou(at)gmail(dot)com>, torikoshia <torikoshia(at)oss(dot)nttdata(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Kirill Reshke <reshkekirill(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [Proposal] Expose internal MultiXact member count function for efficient monitoring |
| Date: | 2025-12-08 04:40:16 |
| Message-ID: | CAExHW5shToKbeiw1eRGeiSyVeCYZUJyw2KUtBKYFn0J3dCGzbA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Dec 6, 2025 at 11:23 PM Naga Appani <nagnrik(at)gmail(dot)com> wrote:
>
> Hi Ashutosh,
>
> Thanks for the review!
>
> I agree - comparing the exposed members_size against the documented
> thresholds is sufficient for monitoring purposes.
>
> This aligns with the approach taken in v11: exposing the current usage in
> a way consistent with other PostgreSQL counters (e.g., XIDs, OIDs), without
> introducing user-visible remaining-capacity calculations whose behavior is
> inconsistent and difficult to interpret externally. In the same spirit, I
> removed oldest_offset: as we discussed, it is internal and does not
> provide an actionable signal to users.
>
> If this addresses the concerns raised so far, I would appreciate
> consideration in moving v11 forward for commit.
The patch at [1] changes the function used to fetch mxid related
information. With that we will get rid of awkwardness around
non-availability of the statistics. It's better to wait for those
changes to get committed before moving this forward.
--
Best Wishes,
Ashutosh Bapat
| From | Date | Subject | |
|---|---|---|---|
| Next Message | VASUKI M | 2025-12-08 04:41:08 | Re: BUG #19095: Test if function exit() is used fail when linked static |
| Previous Message | Nitin Jadhav | 2025-12-08 04:38:00 | Re: Fix crash during recovery when redo segment is missing |