| From: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> |
|---|---|
| To: | Steve Chavez <steve(at)supabase(dot)io> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] clarify palloc comment on quote_literal_cstr |
| Date: | 2025-04-08 03:17:53 |
| Message-ID: | CAExHW5sMbeyJgtq=Bk3f2AwmLBrTwoocxUD4Tq_4qUk_Hs04Xw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Apr 8, 2025 at 12:08 AM Steve Chavez <steve(at)supabase(dot)io> wrote:
>
> I haven't found a similar style of comment on any other function call.
>
> I've attached a new patch using the style you suggest.
>
> That being said, I do find the first form much more readable, but I understand this is a debatable subject.
Thanks for addressing the comment.
In PG code, we start a multiline comment with just /* on the first
line and end with just */ on the last line. All the lines in-between
start with * . Please check other comments in the file.
I would write a., b. c. d. on separate lines.
--
Best Wishes,
Ashutosh Bapat
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Yugo NAGATA | 2025-04-08 03:28:57 | Re: Extend ALTER DEFAULT PRIVILEGES for large objects |
| Previous Message | David Rowley | 2025-04-08 03:00:32 | Re: [PoC] Reducing planning time when tables have many partitions |