Re: Improving connection scalability: GetSnapshotData()

Em sex., 24 de jul. de 2020 às 14:16, Andres Freund <andres(at)anarazel(dot)de>
escreveu:

> On 2020-07-24 14:05:04 -0300, Ranier Vilela wrote:
> > Latest Postgres
> > Windows 64 bits
> > msvc 2019 64 bits
> >
> > Patches applied v12-0001 to v12-0007:
> >
> > C:\dll\postgres\contrib\pgstattuple\pgstatapprox.c(74,28): warning
> C4013:
> > 'GetOldestXmin' indefinido; assumindo extern retornando int
> > [C:\dll\postgres
> > C:\dll\postgres\contrib\pg_visibility\pg_visibility.c(569,29): warning
> > C4013: 'GetOldestXmin' indefinido; assumindo extern retornando int
> > [C:\dll\postgres\pg_visibility.
> > vcxproj]
> > C:\dll\postgres\contrib\pgstattuple\pgstatapprox.c(74,56): error C2065:
> > 'PROCARRAY_FLAGS_VACUUM': identificador nao declarado
> > [C:\dll\postgres\pgstattuple.vcxproj]
> > C:\dll\postgres\contrib\pg_visibility\pg_visibility.c(569,58): error
> > C2065: 'PROCARRAY_FLAGS_VACUUM': identificador nao declarado
> > [C:\dll\postgres\pg_visibility.vcxproj]
> > C:\dll\postgres\contrib\pg_visibility\pg_visibility.c(686,70): error
> > C2065: 'PROCARRAY_FLAGS_VACUUM': identificador nao declarado
> > [C:\dll\postgres\pg_visibility.vcxproj]
>
> I don't know that's about - there's no call to GetOldestXmin() in
> pgstatapprox and pg_visibility after patch 0002? And similarly, the
> PROCARRAY_* references are also removed in the same patch?
>
Maybe need to remove them from these places, not?
C:\dll\postgres\contrib>grep -d GetOldestXmin *.c
File pgstattuple\pgstatapprox.c:
OldestXmin = GetOldestXmin(rel, PROCARRAY_FLAGS_VACUUM);
File pg_visibility\pg_visibility.c:
OldestXmin = GetOldestXmin(NULL, PROCARRAY_FLAGS_VACUUM);
* deadlocks, because surely
GetOldestXmin() should never take
RecomputedOldestXmin = GetOldestXmin(NULL,
PROCARRAY_FLAGS_VACUUM);

regards,
Ranier Vilela