| From: | Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> |
|---|---|
| To: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
| Cc: | David Rowley <dgrowleyml(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Signed vs Unsigned (take 2) (src/backend/storage/ipc/procarray.c) |
| Date: | 2021-07-15 13:04:14 |
| Message-ID: | CAEudQAreER0YT1gxiUCRCt0PqibUBCqqbvQ6579U0dx-iHN9RA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Em qui., 15 de jul. de 2021 às 10:01, Aleksander Alekseev <
aleksander(at)timescale(dot)com> escreveu:
> Thanks, David.
>
> > I lost where. Can you show me?
>
> See the attached warnings.txt.
>
Thank you.
>
> > But the benchmark came from:
> > pgbench -i -p 5432 -d postgres
> > pgbench -c 50 -T 300 -S -n
>
> I'm afraid this tells nothing unless you also provide the
> configuration files and the hardware description, and also some
> information on how you checked that there is no performance
> degradation on all the other supported platforms and possible
> configurations.
> Benchmarking is a very complicated topic - trust me,
> been there!
>
Absolutely.
>
> It would be better to submit two separate patches, the one that
> addresses Size_t and another that addresses shadowing. Refactorings
> only, nothing else.
>
> Regarding the code formatting, please see src/tools/pgindent.
>
I will try.
regards,
Ranier Vilela
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ibrar Ahmed | 2021-07-15 13:16:43 | Re: Asymmetric partition-wise JOIN |
| Previous Message | Ibrar Ahmed | 2021-07-15 13:02:28 | Re: BUG #16583: merge join on tables with different DB collation behind postgres_fdw fails |