| From: | Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> |
|---|---|
| To: | Greg Nancarrow <gregn4422(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Mahendra Singh Thalor <mahi6run(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Fix uninitialized variable access (src/backend/utils/mmgr/freepage.c) |
| Date: | 2021-08-17 14:27:42 |
| Message-ID: | CAEudQArMdeJjbaL5Vs5--3HhZF7qcg2OH0Ea-GnZ-HfLkXET3A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Em ter., 17 de ago. de 2021 às 10:22, Greg Nancarrow <gregn4422(at)gmail(dot)com>
escreveu:
> On Tue, Aug 17, 2021 at 9:13 PM Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> wrote:
> >
> > If that's conditions happen, all *result.index* touches are garbage.
> >
>
> The patch looks valid to me, as the "index" member is not set in the
> "btp == NULL" case, and so has a junk value in the caller, and it's
> being used to index an array,
> BUT - isn't it also necessary to set the "split_pages" member to 0,
> because it also is not currently being set, and so too will have a
> junk value in this case (and it's possible for it to be referenced by
> the caller in this case).
>
I agree.
Attached new version (v1).
regards,
Ranier Vilela
| Attachment | Content-Type | Size |
|---|---|---|
| fix_unitialized_var_index_freepage-v1.patch | application/octet-stream | 417 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2021-08-17 14:36:45 | Re: automatically generating node support functions |
| Previous Message | Tom Lane | 2021-08-17 14:13:55 | Re: A problem in ExecModifyTable |