| From: | Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> |
|---|---|
| To: | Karina Litskevich <litskevichkarina(at)gmail(dot)com> |
| Cc: | marko(at)joh(dot)to, Alexander Lakhin <exclusion(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Avoid unused value (src/fe_utils/print.c) |
| Date: | 2023-07-24 22:04:27 |
| Message-ID: | CAEudQArF9a8uVpFZoGHYSc3ZYy2Swiyn_Zcm7yGjN_Smfbpb1A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Em sex., 21 de jul. de 2023 às 09:13, Karina Litskevich <
litskevichkarina(at)gmail(dot)com> escreveu:
>
>
> On Wed, Jul 12, 2023 at 1:46 AM Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> wrote:
>
>> As there is consensus to keep the no-op assignment,
>> I will go ahead and reject the patch.
>>
>
> In your patch you suggest removing two assignments, and we only have
> consensus to keep one of them. The other one is an obvious no-op.
>
> I attached a patch that removes only one assignment. Could you please try
> it and check whether Coverity is still complaining about need_recordsep
> variable?
>
Yeah.
Checked today, Coverity does not complain about need_recordsep.
best regards,
Ranier Vilela
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2023-07-24 22:46:05 | Re: Improve pg_stat_statements by making jumble handle savepoint names better |
| Previous Message | Robert Haas | 2023-07-24 20:17:56 | Re: odd buildfarm failure - "pg_ctl: control file appears to be corrupt" |