Simplifies checks (src/bin/pg_dump/pg_backup_archiver.c)

From: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>
To: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Simplifies checks (src/bin/pg_dump/pg_backup_archiver.c)
Date: 2026-03-09 13:07:19
Message-ID: CAEudQArCHrLpEKHfuH7mRDaN43rughGfND1n+EuvHMx9zJOAuw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi.

Per Coverity.

Coverity has some alerts about the function *RestoreArchive*,
arguing that there are null variable dereferences.

I haven't done in-depth research to determine if this is correct or not.
However, the code can be simplified to a single check that would silence
notifications and protect against this issue.

patch attached.

best regards,
Ranier Vilela

Attachment Content-Type Size
simplifies-checks-pg_basebackup_archiver.patch application/octet-stream 1.0 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2026-03-09 13:07:47 Re: pg_combinebackup: incorrect size of VM fork after combine
Previous Message Jim Jones 2026-03-09 13:02:06 Re: ALTER TABLE: warn when actions do not recurse to partitions