Re: Avoid a possible null pointer (src/backend/utils/adt/pg_locale.c)

From: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Avoid a possible null pointer (src/backend/utils/adt/pg_locale.c)
Date: 2023-09-02 12:13:11
Message-ID: CAEudQAr6uCWQq2F-3pPJ+RO7btn4Mrr8opno-Cs-56wby0CQkQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Em sex., 1 de set. de 2023 às 17:17, Robert Haas <robertmhaas(at)gmail(dot)com>
escreveu:

> On Fri, Sep 1, 2023 at 11:47 AM Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> wrote:
> > If a null locale is reached in these paths.
> > elog will dereference a null pointer.
>
> True. That's sloppy coding.
>
> I don't know enough about this code to be sure whether the error
> messages that you propose are for the best.
>
I tried to keep the same behavior as before.
Note that if the locale equals COLLPROVIDER_LIBC,
the message to the user will be the same.

best regards,
Ranier Vilela

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dilip Kumar 2023-09-02 12:42:01 Re: Impact of checkpointer during pg_upgrade
Previous Message Tatsuo Ishii 2023-09-02 11:46:34 Re: Incremental View Maintenance, take 2