| From: | Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> |
|---|---|
| To: | John Naylor <john(dot)naylor(at)enterprisedb(dot)com> |
| Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Small miscellaneus fixes (Part II) |
| Date: | 2023-01-16 11:20:46 |
| Message-ID: | CAEudQAr+vQUDF1KXucG0B2+cBjPDFUZY8hsS1_660hpaE=0-cg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Em seg., 16 de jan. de 2023 às 03:28, John Naylor <
john(dot)naylor(at)enterprisedb(dot)com> escreveu:
>
> I wrote:
> > ...but arguably the earlier check is close enough that it's silly to
> assert in the "else" branch, and I'd be okay with just nuking those lines.
> Another thing that caught my attention is the assumption that unsetting a
> bit is so expensive that we have to first check if it's set, so we may as
> well remove "IS_BRACKET(Np->Num)" as well.
>
> The attached is what I mean. I'll commit this this week unless there are
> objections.
>
+1 looks good to me.
regards,
Ranier Vilela
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Juan José Santamaría Flecha | 2023-01-16 12:05:12 | Re: Using AF_UNIX sockets always for tests on Windows |
| Previous Message | Peter Eisentraut | 2023-01-16 11:18:08 | Re: Allow tailoring of ICU locales with custom rules |