[PATCH] remove condition always true (/src/backend/access/heap/vacuumlazy.c)

From: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: [PATCH] remove condition always true (/src/backend/access/heap/vacuumlazy.c)
Date: 2020-03-30 18:07:40
Message-ID: CAEudQAqrB_Hz6q4vC43mBPBoqoQYvS_+=QG1c9bVhrcWYjQ6dw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,
I'm not sure that the patch is 100% correct.
But the fix is about expression about always true.
But if this patch is correct, he fix one possible bug.

The comment says:
* Perform checking of FSM after releasing lock, the fsm is
* approximate, after all.

But this is not what the code does, apparently it checks before unlocking.

best regards,
Ranier Vilela

Attachment Content-Type Size
remove_condition_always_true.patch application/octet-stream 850 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2020-03-30 18:10:30 Re: pgsql: Improve handling of parameter differences in physical replicatio
Previous Message Alexey Kondratov 2020-03-30 18:02:22 Re: Allow CLUSTER, VACUUM FULL and REINDEX to change tablespace on the fly