Re: Signed vs Unsigned (take 2) (src/backend/storage/ipc/procarray.c)

Em dom., 13 de jun. de 2021 às 09:43, Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>
escreveu:

> Hi Andres, thanks for taking a look.
>
> Em sáb., 12 de jun. de 2021 às 16:27, Andres Freund <andres(at)anarazel(dot)de>
> escreveu:
>
>> Hi,
>>
>> On 2021-06-12 10:55:22 -0300, Ranier Vilela wrote:
>> > With the recent changes at procarray.c, I take a look in.
>> > msvc compiler, has some warnings about signed vs unsigned.
>>
>> > 1. Size_t is weird, because all types are int.
>>
>> Not sure why I ended up using size_t here. There are cases where using a
>> natively sized integer can lead to better code being generated, so I'd
>> want to see some evaluation of the code generation effects.
>>
> Yes, sure.
>
I'm a little confused by the msvc compiler, but here's the difference in
code generation.
Apart from the noise caused by unnecessary changes regarding the names.

Microsoft (R) C/C++ Optimizing Compiler Versão 19.28.29915 para x64

diff attached.

regards,
Ranier Vilela