| From: | Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> |
|---|---|
| To: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
| Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Avoid possible dereference null pointer (src/backend/utils/cache/relcache.c) |
| Date: | 2025-06-17 13:31:13 |
| Message-ID: | CAEudQAqnXgR8FW0O4_gori=i6WuNfWmaXypaayF4j8yvxesf+g@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Em ter., 17 de jun. de 2025 às 10:09, Aleksander Alekseev <
aleksander(at)timescale(dot)com> escreveu:
> Hi,
>
> >> We would be in serious trouble if RelationReloadNailed() could be
> >> called for a non-existing relation. Wouldn't Assert() be more
> >> appropriate?
> >
> > IMO, I think no.
> >
> > In all paths, this check is done, why would this be the only exception?
>
> We use Asserts() for cases that shouldn't happen in practice for
> performance reasons.
If you are concerned about performance in this case,
you can rest assured.
> Since this code doesn't crash.
No, you can't be sure.
> I suspect this is
> one of such cases. Unless you are aware of a specific scenario that
> makes the code crash of course.
>
ScanPgRelation really can fail, better make sure.
best regards,
Ranier Vilela
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2025-06-17 13:35:55 | Re: Non-reproducible AIO failure |
| Previous Message | Aleksander Alekseev | 2025-06-17 13:09:00 | Re: Avoid possible dereference null pointer (src/backend/utils/cache/relcache.c) |