| From: | Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Michael Paquier <michael(at)paquier(dot)xyz>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Peter Geoghegan <pg(at)bowt(dot)ie> |
| Subject: | Re: Out-of-memory error reports in libpq |
| Date: | 2021-07-29 11:23:17 |
| Message-ID: | CAEudQAqZ0-j8AxjA8Kc0pw2UuxViBogAjjLZkzkY21w-UEQ-kQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Em qui., 29 de jul. de 2021 às 04:02, Peter Smith <smithpb2250(at)gmail(dot)com>
escreveu:
> (This is not a code review - this is just to satisfy my curiosity)
>
> I've seen lots of code like this where I may have been tempted to use
> a ternary operator for readability, so I was wondering is there a PG
> convention to avoid such ternary operator assignments, or is it simply
> a personal taste thing, or is there some other reason?
>
> For example:
>
> if (msg)
> res->errMsg = msg;
> else
> res->errMsg = libpq_gettext("out of memory\n");
>
The C compiler will expand:
res->errMsg = msg ? msg : libpq_gettext("out of memory\n");
to
if (msg)
res->errMsg = msg;
else
res->errMsg = libpq_gettext("out of memory\n");
What IMHO is much more readable.
regards,
Ranier Vilela
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amul Sul | 2021-07-29 11:52:21 | Re: [Patch] ALTER SYSTEM READ ONLY |
| Previous Message | Ranier Vilela | 2021-07-29 11:17:41 | Re: Out-of-memory error reports in libpq |