Re: [PATCH'] Variables assigned with values that is never used.

From: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH'] Variables assigned with values that is never used.
Date: 2020-04-16 22:21:56
Message-ID: CAEudQAqJ=MVqJd4MHi=iMLismngE4GJqdiEZa1isxF3Pem-udg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Em sáb., 28 de mar. de 2020 às 10:33, Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>
escreveu:

> Hi,
>
> Theses variables, are assigned with values that never is used and, can
> safely have their values removed.
>
1.
https://github.com/postgres/postgres/commit/f0ca378d4c139eda99ef14998115c1674dac3fc5

diff --git a/src/backend/access/nbtree/nbtsplitloc.c
b/src/backend/access/nbtree/nbtsplitloc.c
index 8ba055be9e..15ac106525 100644
--- a/src/backend/access/nbtree/nbtsplitloc.c
+++ b/src/backend/access/nbtree/nbtsplitloc.c
@@ -812,7 +812,6 @@ _bt_bestsplitloc(FindSplitData *state, int
perfectpenalty,

if (penalty <= perfectpenalty)
{
- bestpenalty = penalty;
lowsplit = i;
break;
}

Coincidence? I think not.

regards,
Ranier Vilela

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jehan-Guillaume de Rorthais 2020-04-16 22:23:27 Re: documenting the backup manifest file format
Previous Message Andres Freund 2020-04-16 22:12:07 Re: [DOC] Document concurrent index builds waiting on each other