| From: | Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> |
|---|---|
| To: | Artur Zakirov <zaartur(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Eval expression R/O once time (src/backend/executor/execExpr.c) |
| Date: | 2021-10-01 10:04:03 |
| Message-ID: | CAEudQApoeDkmXKSB2B6MjUtrcz9uMKvp2vAHx1+gvAgD0LYgng@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Em sex., 1 de out. de 2021 às 06:55, Artur Zakirov <zaartur(at)gmail(dot)com>
escreveu:
> On Wed, Sep 22, 2021 at 1:12 AM Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> wrote:
> > Anyway, the v1 patch fixes only the expression eval.
>
> The patch looks good to me.
>
> It seems that initially the code looked similar to your patch. See the
> commit b8d7f053c5c2bf2a7e8734fe3327f6a8bc711755. Then the variables
> were moved to foreach scope by the commit
> 1ec7679f1b67e84be688a311dce234eeaa1d5de8.
>
Thanks for the search.
It seems that 1ec7679f1b67e84be688a311dce234eeaa1d5de8 caused the problem.
> I'll mark the patch as Ready for Commiter.
>
Thank you.
regards,
Ranier Vilela
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2021-10-01 10:13:53 | Re: Improve join selectivity estimation using extended statistics |
| Previous Message | Artur Zakirov | 2021-10-01 09:55:37 | Re: Eval expression R/O once time (src/backend/executor/execExpr.c) |