Re: Operands don't affect result (CONSTANT_EXPRESSION_RESULT) (src/backend/utils/adt/jsonfuncs.c)

From: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Operands don't affect result (CONSTANT_EXPRESSION_RESULT) (src/backend/utils/adt/jsonfuncs.c)
Date: 2021-02-11 21:56:13
Message-ID: CAEudQAp5vEOKzu7j7d2VHTXjKm=6CvC8SrbC3TTR0RWcDn1dQQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Em qui., 11 de fev. de 2021 às 14:51, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> escreveu:

> Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> writes:
> > Em qui., 11 de fev. de 2021 às 01:46, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
> escreveu:
> >> At the same time, I think this code could be improved; but the way
> >> to do that is to use strtoint(), rather than kluging the choice of
> >> datatype even further.
>
> > No matter the function used strtol or strtoint, push_path will remain
> > broken with Windows 64bits.
>
> There is quite a lot of difference between "broken" and "my compiler
> generates pointless warnings". Still, I changed it to use strtoint(),
> because that's simpler and better style.
>
Thanks Tom, for fixing this.

regards,
Ranier Vilela

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Melanie Plageman 2021-02-11 22:02:18 Re: Parallel Full Hash Join
Previous Message Robert Haas 2021-02-11 21:56:06 Re: Is Recovery actually paused?