Re: Avoid redudant initialization and possible memory leak (src/backend/parser/parse_relation.c)

From: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Avoid redudant initialization and possible memory leak (src/backend/parser/parse_relation.c)
Date: 2022-09-13 15:44:40
Message-ID: CAEudQAo0h2Xm-z7h1Bd-+QPM3X6ahZvpwnf7pEs0haasAcUr+Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Em ter., 13 de set. de 2022 às 11:09, Alvaro Herrera <
alvherre(at)alvh(dot)no-ip(dot)org> escreveu:

> On 2022-Sep-13, Ranier Vilela wrote:
>
> > However, for Postgres 15 this may can cause a small memory leak.
>
> What memory leak? There's no leak here.
>
Yeah, as per Julien's answer, there is really no memory leak, but just
unnecessary double execution of pstrdup.
But for Postgres 15, I believe it's worth avoiding this, because it's
wasted cycles.
For Postgres 16, I believe this will be fixed as well, but for robustness,
better fix soon, IMO.

regards,
Ranier Vilela

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jonathan S. Katz 2022-09-13 15:47:16 Re: First draft of the PG 15 release notes
Previous Message Tom Lane 2022-09-13 15:16:02 Re: Can we avoid chdir'ing in resolve_symlinks() ?