| From: | Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> |
|---|---|
| To: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(at)paquier(dot)xyz>, Robert Haas <robertmhaas(at)gmail(dot)com>, dilipbalaut(at)gmail(dot)com, Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | Re: Move pg_attribute.attcompression to earlier in struct for reduced size? |
| Date: | 2021-06-05 14:16:20 |
| Message-ID: | CAEudQAo-GAT_u4rbb=TULSUwpuVq9oJ4ZbfMax7L+_=k4FU3xw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> > Now, while this patch does seem to work correctly, it raises a number of
> > weird cpluspluscheck warnings, which I think are attributable to the
> > new macro definitions. I didn't look into it closely, but I suppose it
> > should be fixable given sufficient effort:
>
> Didn't test, but the first one is certainly fixable by adding a cast,
> and I guess the others might be as well.
>I get no warnings with this one. I'm a bit wary of leaving
>VARDATA_COMPRESSED_GET_EXTSIZE unchanged, but at least nothing in this
>patch requires a cast there.
Hi Alvaro.
Please, would you mind testing with these changes.
I'm curious to see if anything improves or not.
1. Add a const to the attr parameter.
2. Remove the cmid variable (and store it).
3. Add tail cut.
regards,
Ranier Vilela
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0002-Reduce-overhead-of-TOAST-recompression-on-table-r.patch | application/octet-stream | 3.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fabien COELHO | 2021-06-05 14:31:32 | Re: Failures with gcd functions with GCC snapshots GCC and -O3 (?) |
| Previous Message | vignesh C | 2021-06-05 13:32:28 | Re: Added schema level support for publication. |