| From: | Gyan Sreejith <gyan(dot)sreejith(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Kuroda, Hayato/黒田 隼人 <kuroda(dot)hayato(at)fujitsu(dot)com>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Peter Smith <smithpb2250(at)gmail(dot)com> |
| Subject: | Re: [Proposal] Adding Log File Capability to pg_createsubscriber |
| Date: | 2026-03-21 23:09:05 |
| Message-ID: | CAEqnbaVF0yXQk=VVzr-8V23E=iUpUqyah6hxx2fy0ZVJh+CaGA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Mar 21, 2026 at 5:57 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> Based on the above information, can we consider renaming the above
functions to report_createsub_log() and report_createsub_fatal()?
>
> Other than the above point, 0001 LGTM.
>
I have renamed the functions.
Regards,
Gyan
| Attachment | Content-Type | Size |
|---|---|---|
| v16-0001-pg_createsubscriber-use-own-reporting-functions.patch | application/octet-stream | 60.2 KB |
| v16-0002-Add-a-new-argument-l-logdir-to-pg_createsubscrib.patch | application/octet-stream | 15.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Mihail Nikalayeu | 2026-03-21 23:50:00 | Re: Resetting snapshots during the first phase of [CREATE |RE]INDEX CONCURRENTLY |
| Previous Message | Peter Geoghegan | 2026-03-21 23:01:44 | Re: index prefetching |