| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Gyan Sreejith <gyan(dot)sreejith(at)gmail(dot)com> |
| Cc: | Kuroda, Hayato/黒田 隼人 <kuroda(dot)hayato(at)fujitsu(dot)com>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Peter Smith <smithpb2250(at)gmail(dot)com> |
| Subject: | Re: [Proposal] Adding Log File Capability to pg_createsubscriber |
| Date: | 2026-03-21 09:57:40 |
| Message-ID: | CAA4eK1JiAzaY7UYnya7uDhX-kAL1PrsOAxBtys7c35t4q4H3_A@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Mar 20, 2026 at 10:30 PM Gyan Sreejith <gyan(dot)sreejith(at)gmail(dot)com> wrote:
>
0001:
=====
*
+static void pg_createsub_log(enum pg_log_level, enum pg_log_part,
+ const char *pg_restrict fmt,...)
+ pg_attribute_printf(3, 4);
+pg_noreturn static void pg_fatal(const char *pg_restrict fmt,...)
+ pg_attribute_printf(1, 2);
I see similar functions in other modules are named a bit differently.
For example, see report_manifest_error(), report_backup_error(),
report_fatal_error(). Then I see many other error reporting functions
named similarly in code, some examples are: report_invalid_record(),
report_invalid_page(), report_namespace_conflict(), and
report_recovery_conflict().
Based on the above information, can we consider renaming the above
functions to report_createsub_log() and report_createsub_fatal()?
Other than the above point, 0001 LGTM.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Lakhin | 2026-03-21 10:00:00 | Re: SQL Property Graph Queries (SQL/PGQ) |
| Previous Message | ls7777 | 2026-03-21 08:59:11 | Re: Patch for migration of the pg_commit_ts directory |