| From: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
|---|---|
| To: | Euler Taveira <euler(at)eulerto(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Proposal: Cascade REPLICA IDENTITY changes to leaf partitions |
| Date: | 2025-12-17 07:56:18 |
| Message-ID: | CAEoWx2n_HX+epVG0rfMfKeDgBeaZHuYpP4Rtsv+JsydQ+WHjeA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Amit and Euler,
Thank you both for all your advice. Here comes my first implementation of
INHERIT in the attached v2 patch.
On Wed, Dec 17, 2025 at 8:11 AM Euler Taveira <euler(at)eulerto(dot)com> wrote:
> I wondering if we use INHERIT as default. The main advantage is usability
> as Chao
> Li already mentioned. Is there any cases that having a different replica
> identity from parent/partitioned table makes sense?
>
>
We can leave this topic open for discussion. In my current implementation,
NO INHERIT is still the default. But if we decide to switch the default, I
can add a new commit that should include only 1 line code change in gram.y
and a tiny doc update.
0001 - when a new partition is created, use the parent's replication
identity
0002 - add INHERIT | NO INHERIT
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0002-Add-INHERIT-NO-INHERIT-options-to-ALTER-TABLE-REP.patch | application/octet-stream | 13.7 KB |
| v2-0001-Inherit-replica-identity-for-new-and-attached-par.patch | application/octet-stream | 8.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2025-12-17 08:11:19 | Re: [Proposal] Adding callback support for custom statistics kinds |
| Previous Message | Bertrand Drouvot | 2025-12-17 07:30:35 | Re: relfilenode statistics |