| From: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: backend/nodes cleanup: Move loop variables definitions into for statement |
| Date: | 2025-11-24 23:38:23 |
| Message-ID: | CAEoWx2nFKbpTR3X_jAVj-tgHWKpsYVy5ppmHinR91LFiHtQw5g@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Nov 24, 2025 at 11:00 PM Peter Eisentraut <peter(at)eisentraut(dot)org>
wrote:
> On 19.11.25 11:32, Chao Li wrote:
> > On Wed, Nov 19, 2025 at 5:36 PM Peter Eisentraut <peter(at)eisentraut(dot)org
> > <mailto:peter(at)eisentraut(dot)org>> wrote:
> >
> >
> >
> > In a couple of cases, you are changing the type of the loop variable
> > from Size to int. I would not expect such a change in a patch of
> this
> > nature. If you have a reason to change it, please explain it (but I
> > doubt the change is correct).
> >
> >
> > That was a mistake. I fixed it in v3.
>
> Still not correct in outDatum().
>
>
Oops! Fixed in v4.
Best regards,
Chao Li (Evan)
---------------------
HighGo Software Co., Ltd.
https://www.highgo.com/
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-backend-nodes-cleanup-Move-loop-variables-definit.patch | application/octet-stream | 8.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeff Davis | 2025-11-24 23:57:43 | Re: Remaining dependency on setlocale() |
| Previous Message | Masahiko Sawada | 2025-11-24 23:32:36 | Re: psql: tab-completion support for COPY ... TO/FROM STDIN, STDOUT, and PROGRAM |