| From: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
|---|---|
| To: | Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org> |
| Cc: | Peter Eisentraut <peter(at)eisentraut(dot)org>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: gen_guc_tables.pl: Validate required GUC fields before code generation |
| Date: | 2025-11-20 05:51:56 |
| Message-ID: | CAEoWx2ksUC-PW4VKAA5uGit1KyH3qCmJ5xMiMwUheSUUWtzKcw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Nov 19, 2025 at 7:56 PM Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>
wrote:
>
> > v3 goes back to v1 plus I add a check for unknown field type per your
> > suggestion, for example:
> > ```
> > error: guc_parameters.data line 2271: unknown GUC type 'intt'
> > ```
>
> We've already validated that the name field exists, so this error
> message should include that, like the other ones do.
>
Make sense. I added field name to this error message in v4, now it looks
like:
```
error: guc_parameters.dat line 2278: 'primary_conninfo' has unknown GUC
type 'string1'
```
Chao Li (Evan)
---------------------
HighGo Software Co., Ltd.
https://www.highgo.com/
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-gen_guc_tables.pl-Validate-required-GUC-fields-be.patch | application/octet-stream | 3.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Haruna Miwa | 2025-11-20 06:04:58 | Re: Add MERGE and VALUES statements to tab completion for PREPARE |
| Previous Message | Илья Чердаков | 2025-11-20 05:46:43 | Re: Add uuid_to_base32hex() and base32hex_to_uuid() built-in functions |