Fixes a typo in tablecmd

From: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
To: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Fixes a typo in tablecmd
Date: 2025-12-14 23:25:56
Message-ID: CAEoWx2=Aib+catZn6wHKmz0BWe8-q10NAhpxu8wUDT19SddKNA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Hackers,

I noticed this while working on a patch with tablecmd:

```
/*
* If the table at either end of the constraint is partitioned, we need to
* recurse and handle every unvalidate constraint that is a child of this
* constraint.
*/
```

Here “unvalidate” looks abnormal to me but not an obvious spelling error.
Then I searched over the source tree, and found two similar occurrences:

Also in tablecmd.c
```
/* an unvalidated constraint is no good */
```

In pg_dump.c
```
/*
* An unvalidated constraint needs to be dumped separately, so
* that potentially-violating existing data is loaded before
* the constraint.
*/
```

Notice the difference: “unvalidate” vs “unvalidated”.

Then I recalled that Tom referred to the online dictionary
https://www.onelook.com for checking typo in discussion [1], and I checked
with the web site. It shows that “unvalidate” is not found; and
“unvalidated” has 3 matches and means “not confirmed as true yet”.

So, I believe “unvalidate” is a typo, a “d” should be appended.

[1] https://postgr.es/m/2118725.1762837193@sss.pgh.pa.us

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

Attachment Content-Type Size
v1-0001-Fixes-a-typo-in-tablecmd.patch application/octet-stream 1010 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Smith 2025-12-15 00:25:55 Re: DOCS - Clarify the publication 'publish_via_partition_root' default value.
Previous Message Tomas Vondra 2025-12-14 23:02:53 Re: Trying out read streams in pgvector (an extension)