| From: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Trivial patch to fix a typo |
| Date: | 2025-08-01 07:16:18 |
| Message-ID: | CAEoWx2=2YZpYSGFxZNfaqPhiE2nX1h=Q_fnW54n_uY0dLRZ8ig@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Ah ... Good to learn. Attached v2 updated the out file as well, now the
test passed:
$ make check
...
# All 229 tests passed.
Thanks a lot.
Chao Li (Evan)
------------------------------
HighGo Software Inc.
https://www.highgo.com/
Michael Paquier <michael(at)paquier(dot)xyz> 于2025年8月1日周五 15:04写道：
> On Fri, Aug 01, 2025 at 02:56:33PM +0800, Chao Li wrote:
> > I happened to catch this typo while reading the regression test code, so
> > submitting a fix.
> >
> > As the typo is in the code comment, no test needs to run.
>
> Incorrect. The comment is included in the generated output, impacting
> also foreign_key.out. If you run a simple `make check` you would see
> that the tests fail.
> --
> Michael
>
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Fixed-a-typo-in-src-test-regress-sql-foreign_key..patch | application/octet-stream | 1.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2025-08-01 07:18:11 | Re: [WIP]Vertical Clustered Index (columnar store extension) - take2 |
| Previous Message | Michael Paquier | 2025-08-01 07:04:23 | Re: Trivial patch to fix a typo |