| From: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, Christoph Berg <myon(at)debian(dot)org>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Log LDAP "diagnostic messages"? |
| Date: | 2017-10-13 04:37:30 |
| Message-ID: | CAEepm=0quy9uCyhuV8fS2mPzca88yiv=pg8FbQPxFfW7Bu2QAA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Oct 13, 2017 at 3:59 PM, Peter Eisentraut
<peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
> On 9/24/17 07:00, Thomas Munro wrote:
>> Fair point. In that case there are a few others we should consider
>> moving down too for consistency, like in the attached.
>
>> Thanks, that is much tidier. Done that way in the attached.
>>
>> Here also is a small addition to your TAP test which exercises the
>> non-NULL code path because slapd rejects TLS by default with a
>> diagnostic message. I'm not sure if this is worth adding, since it
>> doesn't actually verify that the code path is reached (though you can
>> see that it is from the logs).
>
> Committed.
Thanks, and thanks also for follow-up commit 7d1b8e75. Looks like the
new macro arrived in OpenLDAP 2.4 but RHEL5 shipped with 2.3.
--
Thomas Munro
http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2017-10-13 05:02:29 | Re: BLK_DONE state in XLogReadBufferForRedoExtended |
| Previous Message | Michael Paquier | 2017-10-13 04:29:32 | Re: BUG #14849: jsonb_build_object doesn't like VARIADIC calls very much |