| From: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: WIP: Barriers |
| Date: | 2017-01-06 19:32:07 |
| Message-ID: | CAEepm=3g3EC734kgriWseiJPfUQZeoMWdhAfzOc0ecewAa5uXg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Nov 23, 2016 at 2:28 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> The code here looks OK. A few thoughts:
>
> - I'm a little unsure whether it's a good idea to remove the existing
> barrier.h and immediately add a new barrier.h that does something
> totally different. It's tempting to try to find another name for
> these things just to avoid that. Then again, I bet there's not much
> non-core code that is relying on the existing barrier.h, so maybe it's
> OK. On the third hand, the risk of confusing developers may be
> non-nil even if we don't confuse any code. I think I'll go commit
> remove-useless-barrier-v4.patch now and see if anyone shows up to
> complain...
Here is a new version with updated copyright messages and some dtrace
probes which provide an easy way to measure the time spend waiting at
barriers.
--
Thomas Munro
http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| barrier-v5.patch | application/octet-stream | 8.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2017-01-06 19:44:17 | Re: ALTER TABLE .. ALTER COLUMN .. ERROR: attribute .. has wrong type |
| Previous Message | Tom Lane | 2017-01-06 19:24:56 | Re: Odd behavior with PG_TRY |