| From: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Arthur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru>, Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Tab completion for ALTER DATABASE … SET TABLESPACE |
| Date: | 2018-09-20 21:29:09 |
| Message-ID: | CAEepm=3btrxr2FDPwPc4W73=1SdvXaKV6FqeHgxaWRrzg4PdwQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Sep 21, 2018 at 9:22 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Arthur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru> writes:
> > On Thu, Aug 30, 2018 at 05:54:23PM +0100, Dagfinn Ilmari Mannsåker wrote:
> >> And just after hitting send, I noticed I'd typed ALTER TABLE instead of
> >> ALTER DATABASE, including in the commit message :(
> >> Fixed patch attached.
>
> > The patch seems reasonable. It fixes the lack of tab completion for
> > ALTER DATABASE ... SET TABLESPACE ... .
>
> LGTM too, pushed.
+ else if (Matches5("ALTER", "DATABASE", MatchAny, "SET", "TABLESPACE"))
. o O ( hmm, we now have variadic macros )
--
Thomas Munro
http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2018-09-20 21:58:02 | Re: Making all nbtree entries unique by having heap TIDs participate in comparisons |
| Previous Message | Tom Lane | 2018-09-20 21:22:30 | Re: [PATCH] Tab completion for ALTER DATABASE … SET TABLESPACE |