| From: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
|---|---|
| To: | Peter Moser <pitiz29a(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Johann Gamper <gamper(at)inf(dot)unibz(dot)it>, Michael Böhlen <boehlen(at)ifi(dot)uzh(dot)ch>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Anton Dignös <anton(dot)dignoes(at)unibz(dot)it> |
| Subject: | Re: [PROPOSAL] Temporal query processing with range types |
| Date: | 2017-09-01 04:49:41 |
| Message-ID: | CAEepm=3WfoWnaxEQQYQoGOUZ-ceMJwiXE1ty=iTtCG1M=6658w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Aug 1, 2017 at 12:53 AM, Peter Moser <pitiz29a(at)gmail(dot)com> wrote:
> On 06.04.2017 01:24, Andres Freund wrote:
>>
>> Unfortunately I don't think this patch has received sufficient design
>> and implementation to consider merging it into v10. As code freeze is
>> in two days, I think we'll have to move this to the next commitfest.
>
>
> We rebased our patch on top of commit
> 393d47ed0f5b764341c7733ef60e8442d3e9bdc2
> from "Mon Jul 31 11:24:51 2017 +0900".
Hi Peter,
This patch still applies, but no longer compiles:
nodeTemporalAdjustment.c: In function ‘ExecTemporalAdjustment’:
nodeTemporalAdjustment.c:286:21: error: incompatible types when
assigning to type ‘Form_pg_attribute’ from type
‘FormData_pg_attribute’
node->datumFormat = curr->tts_tupleDescriptor->attrs[tc->attNumP1 - 1];
^
After commits 2cd70845 and c6293249 you need to change expressions of
that format to, for example:
node->datumFormat = TupleDescAttr(curr->tts_tupleDescriptor,
tc->attNumP1 - 1);
Thanks!
--
Thomas Munro
http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2017-09-01 05:11:36 | Re: [Proposal] Allow users to specify multiple tables in VACUUM commands |
| Previous Message | Thomas Munro | 2017-09-01 04:40:01 | Re: Surjective functional indexes |